useStore uses ReadonlyStoreApi #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
Author
|
Let me know if you want me to open a similar PR targeting the v5 branch. |
dai-shi
approved these changes
Jun 5, 2024
Member
dai-shi
left a comment
dai-shi
left a comment
There was a problem hiding this comment.
LGTM
I think I can take care of the rest. Thanks for your contribution!
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
Fixes #2581
Summary
UseBoundStoretypes were relaxed in #1589 because the internals of this method did not use any of the setters, only getters. We can also do this foruseStoretypes because its API only uses getters.Context: I am building a library that returns a store API with only getter methods exposed and I would like folks to be able to pass this directly into Zustand's
useStoreReact helper.Check List
pnpm run prettierfor formatting code and docs