Skip to content

chore(deps): update dev dependencies#1224

Merged
dai-shi merged 6 commits into
mainfrom
chore/update-deps
May 1, 2026
Merged

chore(deps): update dev dependencies#1224
dai-shi merged 6 commits into
mainfrom
chore/update-deps

Conversation

@dai-shi
Copy link
Copy Markdown
Member

@dai-shi dai-shi commented May 1, 2026

for v2.3.2

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
valtio Error Error May 1, 2026 5:50am

Request Review

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented May 1, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Size Change: +168 B (+1.11%)

Total Size: 15.3 kB

Filename Size Change
./dist/esm/vanilla/utils.mjs 3.92 kB +85 B (+2.21%)
./dist/vanilla/utils.js 3.96 kB +83 B (+2.14%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react.mjs 694 B
./dist/esm/react/utils.mjs 271 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla.mjs 2.42 kB
./dist/index.js 243 B
./dist/react.js 686 B
./dist/react/utils.js 292 B
./dist/utils.js 244 B
./dist/vanilla.js 2.46 kB

compressed-size-action

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 1, 2026

More templates

npm i https://pkg.pr.new/valtio@1224

commit: 189e746

@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented May 1, 2026

> valtio@2.3.1 test:types /home/runner/work/valtio/valtio
> tsc --noEmit

Error: src/vanilla/utils/proxyMap.ts(83,9): error TS2322: Type '{ data: V[]; index: number; epoch: number; readonly size: number; get(key: K): V | undefined; has(key: K): boolean; set(key: K, value: V): Map<K, V> & { ...; }; ... 8 more ...; toJSON(): Map<...>; }' is not assignable to type 'InternalProxyObject<K, V>'.
  Type '{ data: V[]; index: number; epoch: number; readonly size: number; get(key: K): V | undefined; has(key: K): boolean; set(key: K, value: V): Map<K, V> & { ...; }; ... 8 more ...; toJSON(): Map<...>; }' is missing the following properties from type 'Map<K, V>': getOrInsert, getOrInsertComputed
 ELIFECYCLE  Command failed with exit code 2.

@overthemike Would you be able to help fixing types?

@overthemike
Copy link
Copy Markdown
Collaborator

Yeah I'll take a look

@overthemike
Copy link
Copy Markdown
Collaborator

overthemike commented May 1, 2026

@dai-shi So this looks like a bit more than just types. getOrInsert and getOrInsertComputed are new in the Map interface. I'm not sure yet what they entail as far as implementation goes. We could probably omit those methods for the time being, although we won't be to spec with map anymore.

@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented May 1, 2026

Got it. Thanks!

@dai-shi dai-shi marked this pull request as ready for review May 1, 2026 06:12
@dai-shi dai-shi merged commit 5c63ee1 into main May 1, 2026
33 of 34 checks passed
@dai-shi dai-shi deleted the chore/update-deps branch May 1, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants