Incorrect Cylinder shape

[tomo0613]

As of new version of cannon-es Cylinder.type is equal to Shape.types.CYLINDER (as it should be).

But so far the debug-renderer handled Cylinders as ConvexPolyhedrons and now every cylinder is represented as the default "CylinderGeometry(0.5, 0.5, 1, 32)"

I'm not sure about the proper fix, but removing the body of "case CYLINDER" in "function createMesh()" leaving as
case CYLINDER: \n case CONVEXPOLYHEDRON: ...
solves the issue,
(the "function typeMatch()" also has not prepared to handle cylinders)

[marcofugaro]

Thanks for the heads up @tomo0613!

Could you test that #7 solves this issue?

[tomo0613]

I tested it.
The createMesh part works.
It wont update as the other shapes, but as I see the scale part is not implemented yet.

[marcofugaro]

It wont update as the other shapes, but as I see the scale part is not implemented yet.

Can you elaborate? What are you doing in these specific cases?

[tomo0613]

In every case of transform (same for cylinder, polyhedron, box...) the current shape is disposed mapElementBody.shapes.length = 0; then a new shape is created with the modified props. so basically the shapes are replaced ( code )

changing this:
|| geometry instanceof CylinderGeometry && shape.type === Shape.types.CYLINDER
to this: (like for polyhedrons, because cylinder is a polyhedrons)
|| geometry.id === shape.geometryId && shape.type === Shape.types.CYLINDER
solves the problem

I think the scale(1, 1, 1) is there because for some shapes scaling not always works, eg.: changing cylinder sides or radiusTop/Bottom

[marcofugaro]

Alright, thanks for the tip, should be fixed now!

Yeah the scale doesn't work for the cylinder.