Increase visibility of CocoaBlock->grow()#6707
Open
ItzxDwi wants to merge 3 commits intopmmp:minor-nextfrom
Open
Increase visibility of CocoaBlock->grow()#6707ItzxDwi wants to merge 3 commits intopmmp:minor-nextfrom
ItzxDwi wants to merge 3 commits intopmmp:minor-nextfrom
Conversation
Contributor
Author
|
I renamed the branch, and github closed PR #6705 automatically. It's basically the same PR just with new branch name. |
ShockedPlot7560
approved these changes
May 25, 2025
Member
|
Per team internals discussions we're currently undecided whether to accept this change or not. It's not clear if it makes sense to do this in isolation (there's plenty of other blocks which implement similar methods). It also constrains the types of changes we can do to this code in minor releases. |
dktapps
added
Category: API
Member
|
No more words. We are all balanced for this change. Any more opinion ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues & PRs
Changes
API changes
CocoaBlock->grow()is now protected instead of privateBehavioural changes
None
Backwards compatibility
None