Skip to content

fix(pie): address some issues with data label prop #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

fix(pie): address some issues with data label prop #967

merged 1 commit into from
May 22, 2020

Conversation

@wyze
Copy link
Contributor

@wyze wyze commented May 22, 2020

  • Fix proptype stating label is required for PieSlice
  • Fix PieLegend to use label if available, otherwise id
  • Add knob to storybook to display legend

Close #794
Close #808

@wyze
fix(pie): address some issues with label
bbc1f23 
- Fix proptype stating label is required for PieSlice
- Fix PieLegend to use label if available, otherwise id
- Add knob to storybook to display legend

Close #794
Close #808
@wyze wyze changed the title fix(pie): address some issues with label fix(pie): address some issues with data label prop May 22, 2020
@wyze wyze merged commit d4714b6 into master May 22, 2020
@wyze wyze deleted the pie-label-fixes branch May 22, 2020 01:59
@wyze wyze mentioned this pull request May 22, 2020
Closed
@wyze wyze restored the pie-label-fixes branch May 22, 2020 02:34
@wyze wyze deleted the pie-label-fixes branch May 22, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@wyze