Skip to content

Conversation

@recurser
Copy link
Contributor

Screen Shot 2020-04-17 at 14 54 10

@recurser
Copy link
Contributor Author

@plouc I couldn't get the test suite to run because I got a lot of these TypeError: Cannot read property 'current' of undefined:

 FAIL  packages/bar/tests/Bar.test.js (5.135s)
  ● should render a basic bar chart

    TypeError: Cannot read property 'current' of undefined

      14 |
      15 | it('should render a basic bar chart', () => {
    > 16 |     const component = renderer.create(
         |                                ^
      17 |         <Bar
      18 |             width={500}
      19 |             height={300}

      at warnIfNotScopedWithMatchingAct (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13713:31)
      at updateContainer (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:14706:7)
      at Object.create (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:15455:5)
      at Object.<anonymous> (packages/bar/tests/Bar.test.js:16:32)

... any advice how to resolve that?

@recurser recurser changed the title Add support to AreaBump for defs and fill properties Add support for defs and fill properties to AreaBump Apr 17, 2020
@wyze
Copy link
Contributor

wyze commented May 19, 2020

Hi Dave, thanks for this! Looks really great. I have not seen that error and the tests run fine for me (make test). What about deleting node_modules and reinstalling?

@recurser
Copy link
Contributor Author

Hi @wyze - all the tests pass after re-installing node_modules 👍 I'm not sure what happened there, but all looks good now.

@wyze wyze changed the title Add support for defs and fill properties to AreaBump feat(bump): add support for defs/fill properties to AreaBump May 23, 2020
@wyze wyze merged commit c5d5d86 into plouc:master May 23, 2020
@plouc
Copy link
Owner

plouc commented May 30, 2020

It has been released in v0.62.0, thank you very much for this feature @recurser! And it's really nice to have included it on the website :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants