Skip to content

fix(line): typings fix for custom layer props #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2020
Merged

fix(line): typings fix for custom layer props #887

merged 2 commits into from
May 19, 2020

Conversation

@stuartlong
Copy link
Contributor

@stuartlong stuartlong commented Mar 3, 2020

Typings fixes for two areas of Line:

  1. adds "catmullRom" as a supported curve string

  2. Populates CustomLayerProps with some more properties

  • it's still missing areaGenerator but I'm not using that so wasn't sure what the proper typing for it would be

@wyze wyze changed the title Typings fix for curve and custom layer fix(line): typings fix for custom layer props May 19, 2020
@wyze wyze merged commit a293a64 into plouc:master May 19, 2020
@wyze
Copy link
Contributor

wyze commented May 19, 2020

Thanks @stuartlong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartlong @wyze