Skip to content

Fix PropType for Line markers when using dates in the X axis. #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plouc merged 3 commits into from
Oct 19, 2019
Merged

Fix PropType for Line markers when using dates in the X axis. #653

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a33d884
Fix PropType for Line markers when using dates in the X axis.
nfvs Jul 29, 2019
9e87a6b
Fixed line props formatting.
nfvs Jul 29, 2019
90d7e78
Allow dates in CartesianMarkers.
nfvs Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/line/src/props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const commonPropTypes = {
markers: PropTypes.arrayOf(
PropTypes.shape({
axis: PropTypes.oneOf(['x', 'y']).isRequired,
value: PropTypes.oneOfType([PropTypes.number, PropTypes.string]).isRequired,
value: PropTypes.oneOfType([PropTypes.number, PropTypes.string, PropTypes.instanceOf(Date)]).isRequired,
style: PropTypes.object,
})
),
Expand Down