-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
keep the tooltip inbounds #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
^ |
|
Is anyone able to review this PR? I'm working on a collection of charts right now that would help resolve the tooltip positioning issue as described in #580. |
|
^ |
|
if anyone wants to make this an optional prop * |
|
Thanks @VintG for the updates! When do you expect for this PR to be merged? |
I don't have write access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the other threads some people requested having this to be enabled as an optional prop, in case user designs intend to have the tooltip alignment in one direction.
|
Hi, when will the PR be done? What is the hold-up? |
|
@VintG Do you know when someone with write-access will be able to merge it? |
|
@plouc firstly, thanks a lot for all the work you have done at Nivo. It's a great library. Is there a way we can merge this? Anything else that needs to get done that I can help with? Seems to be solving the tooltip getting out of viewport issue. |
|
@plouc Any clue about when this will get merged cause I'm really in need of this in my project at work. |
|
Sorry for the long delay, and thank you @humanchimp, I'll probably try to improve the tooltip behaviour at some point, but it seems that this will help a lot of people! |
|
thank you @plouc! |
|
Hi @plouc thanks for merging the pr. Will this be published to npm soon ? |
|
Dear @plouc, I don't mean to put you under pressure but would you kindly publish this on npm? It will be much appreciated. :) |
|
@plouc would be sick to get this published!!!! |
|
Just another check in - was this fix published to npm? |
|
@brycedewitt Yes, it is in v0.60 and above. |
Related to #580
Hello. Thanks for your hard work and great skill writing this library! 🙇
This PR may not be good enough to merge, but I wanted to propose it anyway, given this comment, which suggests that this change (or something like it) could be appropriate. This seems hack-y to me, but I've been using this patch in my own application, and I thought it would be worth sharing. Opening this PR seemed like a good way to share this, even if the PR itself is not mergeable.