Skip to content

Conversation

@humanchimp
Copy link
Contributor

Related to #580

Hello. Thanks for your hard work and great skill writing this library! 🙇

This PR may not be good enough to merge, but I wanted to propose it anyway, given this comment, which suggests that this change (or something like it) could be appropriate. This seems hack-y to me, but I've been using this patch in my own application, and I thought it would be worth sharing. Opening this PR seemed like a good way to share this, even if the PR itself is not mergeable.

@vli777
Copy link

vli777 commented Sep 10, 2019

^

@shihlinlu
Copy link

Is anyone able to review this PR? I'm working on a collection of charts right now that would help resolve the tooltip positioning issue as described in #580.

@nghieptiki
Copy link

^

@vli777
Copy link

vli777 commented Oct 7, 2019

if anyone wants to make this an optional prop *
otherwise, I've been using this modification without issues so far

@shihlinlu
Copy link

Thanks @VintG for the updates! When do you expect for this PR to be merged?

@vli777
Copy link

vli777 commented Oct 8, 2019

Thanks @VintG for the updates! When do you expect for this PR to be merged?

I don't have write access

Copy link

@vli777 vli777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other threads some people requested having this to be enabled as an optional prop, in case user designs intend to have the tooltip alignment in one direction.

@siemvaessen
Copy link

Hi, when will the PR be done? What is the hold-up?

@shihlinlu
Copy link

@VintG Do you know when someone with write-access will be able to merge it?

@novito
Copy link

novito commented Nov 8, 2019

@plouc firstly, thanks a lot for all the work you have done at Nivo. It's a great library. Is there a way we can merge this? Anything else that needs to get done that I can help with? Seems to be solving the tooltip getting out of viewport issue.

@senelithperera
Copy link

senelithperera commented Nov 18, 2019

@plouc Any clue about when this will get merged cause I'm really in need of this in my project at work.

@plouc plouc merged commit 395fc5e into plouc:master Nov 20, 2019
@plouc
Copy link
Owner

plouc commented Nov 20, 2019

Sorry for the long delay, and thank you @humanchimp, I'll probably try to improve the tooltip behaviour at some point, but it seems that this will help a lot of people!

@novito
Copy link

novito commented Nov 21, 2019

thank you @plouc!

@senelithperera
Copy link

senelithperera commented Nov 22, 2019

Hi @plouc thanks for merging the pr. Will this be published to npm soon ?

@taschetto
Copy link

Dear @plouc, I don't mean to put you under pressure but would you kindly publish this on npm? It will be much appreciated. :)

@Jaquin92
Copy link

@plouc would be sick to get this published!!!!

@brycedewitt
Copy link

Just another check in - was this fix published to npm?

@wyze
Copy link
Contributor

wyze commented Jul 30, 2020

@brycedewitt Yes, it is in v0.60 and above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.