feat(axes): add onClick handler to axis ticks #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@plouc I fixed the failing tests. Any chance we can get this merged in soon? Please let me know if there are any other changes you want me to make. |
|
@martingordon, seems OK, thank you. However I think it's useful to also pass event with value, it can be used to determine click position for example, or prevent bubbling in case we a have a click handler higher in the tree. |
|
@plouc Good idea, I just pushed an update. |
|
@martingordon @plouc Can someone update the documentation to reflect this? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this useful in heat maps to allow for additional interactivity (for example, to allow sorting by a row/column label).