Add number support to gridXValues and gridYValues on Line #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plouc
requested changes
Jan 24, 2019
packages/line/src/props.js
Outdated
| gridYValues: PropTypes.arrayOf(PropTypes.oneOfType([PropTypes.number, PropTypes.string])), | ||
| gridXValues: PropTypes.oneOfType([ | ||
| PropTypes.number, | ||
| PropTypes.arrayOf(PropTypes.oneOfType([PropTypes.number, PropTypes.string])), |
Owner
There was a problem hiding this comment.
The line chart also supports Date objects, so you should add PropTypes.instanceOf(Date) to both gridXValues and gridYValues.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback, I wasn't sure about that. I've added it now.
Owner
|
@jasonwells sorry for the late review |
Contributor
Author
|
@plouc Thanks for the input and no worries! |
plouc
approved these changes
Jan 24, 2019
Owner
|
Thank you @jasonwells! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds gridCount/integer support to
gridXValuesandgridYValuesfor line charts. This allows for grid lines and axes ticks to be calculated the same when using a number that is passed. For example:I tried to follow all of the contributing guidelines, happy to contribute to a great library!