Skip to content

Add support for a ref for several charts #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 13, 2025
Merged

Add support for a ref for several charts #2757

merged 9 commits into from
May 13, 2025

Conversation

@plouc
Copy link
Owner

@plouc plouc commented May 12, 2025 •
edited
Loading

  • Bar
  • AreaBump
  • Bump
  • BoxPlot
  • Bullet
  • Calendar
  • CalendarCanvas
  • TimeRange
  • Chord
  • ChordCanvas
  • PolarBar
  • Sankey

@vercel
Copy link

vercel bot commented May 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 3:45am
nivo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 3:45am

@plouc plouc self-assigned this May 12, 2025
@plouc plouc mentioned this pull request May 12, 2025
Closed
@plouc plouc added sankey @nivo/sankey package polar-bar @nivo/polar-bar package labels May 12, 2025
@plouc plouc marked this pull request as ready for review May 13, 2025 04:04
@plouc plouc merged commit e6f29b3 into master May 13, 2025
6 checks passed
@plouc plouc deleted the refs branch May 13, 2025 04:04
@ImLunaHey
Copy link

ImLunaHey commented May 16, 2025

@plouc curious why forwardRef was added when it's deprecated in react 19 and will be removed in future versions. seems like a step back towards react 19 support.

@ImLunaHey ImLunaHey mentioned this pull request May 16, 2025
Closed
@plouc
Copy link
Owner Author

plouc commented May 16, 2025

@ImLunaHey, I still want to support refs for older react versions, which require using forwardRef.
My understanding is that it will be deprecated in future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@plouc plouc

Labels

polar-bar @nivo/polar-bar package sankey @nivo/sankey package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@plouc @ImLunaHey