Skip to content

Conversation

@plouc
Copy link
Owner

@plouc plouc commented Apr 30, 2025

This PR also includes the following changes:

  • Enable tests in storybook and write a first one for Bar
  • @nivo/bar: Add data-testid to BarItem rect element
  • @nivo/tooltip: Add tooltip role to the tooltip wrapper
  • Not really part of the PR, but now we'll have a preview of storybook deployed on vercel, which is useful when PRs include new stories

@plouc plouc self-assigned this Apr 30, 2025
@vercel
Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 3:37pm
nivo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 3:37pm

@plouc plouc force-pushed the upgrade-storybook branch from e487434 to b91c5c1 Compare April 30, 2025 15:04
@plouc plouc marked this pull request as ready for review April 30, 2025 15:16
@plouc plouc merged commit d3d3dc1 into master Apr 30, 2025
6 of 7 checks passed
@plouc plouc deleted the upgrade-storybook branch April 30, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants