-
-
Notifications
You must be signed in to change notification settings - Fork 102
"navigate" event support in toolbar and navigationmarker + other stuff #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thet
wants to merge
24
commits into
master
Choose a base branch
from
thet-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…harm. The benefits for Patternslib BasePattern based Patterns are, for example: - Arguments are specified with default values, units and types. - Option inheritance - options defined on parent elements are inherited for child elements. - Better Integration in the Patternslib framework (event handling, etc).
…sarily and correctly reload for edit forms, hash and query string urls.
…n portal-url, no jQuery.
… after re-scanning. This can be used to do something directly after the re-scanning, e.g. setting details state.
…aks so disabled, parent-selector introduced.
…use window.location. window.location is what the navigate event is about..
…dy tag when the URL changes.
…done directly in pat-base-url.
…tically incorrect wording.
…tate is enough to change the URL and to get pat-base-url active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already a long running and massive PR.
I use it for a ajaxified ClassicUI Plone site and I think it's useful in general.
More on that later, but this is also covered at the "Ajaxify Plone" talk at Ploneconf 2025.
TODO: