[Do not merge] Fiddle with the profile to show how black compatibility can be restored#4265
Closed
ale-rt wants to merge 1 commit into
Closed
[Do not merge] Fiddle with the profile to show how black compatibility can be restored#4265ale-rt wants to merge 1 commit into
ale-rt wants to merge 1 commit into
Conversation
ale-rt
changed the title
ale-rt
commented
Jan 28, 2026
| profile = "plone" | ||
| profile = "black" | ||
| force_alphabetical_sort = true | ||
| force_single_line = true |
Member
Author
There was a problem hiding this comment.
According to:
https://github.com/PyCQA/isort/blob/024aa37e44c9f29964a4fca355a4680fd4511979/isort/profiles.py#L44-L50
the profile plone is equivalent to:
profile = "black"
force_alphabetical_sort = true
force_single_line = true
lines_after_imports = 2
The last line causes the isort and black pre-commit to clash one with the other.
Member
Author
|
Once this is merged we should be good again PyCQA/isort#2457 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to fix the pre-commit for #4264