Improvements in demo & Link to Python version#36
Open
filips123 wants to merge 2 commits intopldespaigne:masterfrom
Open
Improvements in demo & Link to Python version#36filips123 wants to merge 2 commits intopldespaigne:masterfrom
filips123 wants to merge 2 commits intopldespaigne:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains some of the changes that were included in #33:
I created handling for default profiles. If decode example receives unknown profile, it displays it as codec name and adds
utf-8notice. It now also handles few additional content-hash URLs (onion, onion3, zeronet).I also linked my Python implementation from your README and your package from my README. Although this is a bit self-promotion, I think that it would be good to notify developers about other implementations of the content hash in different languages.