Skip to content

Gizmo regression fixes #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 28, 2025
Merged

Gizmo regression fixes #8079

merged 9 commits into from
Oct 28, 2025

Conversation

@kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Oct 28, 2025 •
edited
Loading

Description

  • Fixes scale warping at screen edges on high FOV
  • Adds preventDefault flag for setting whether preventDefault is called on internal pointer events (for splicing with mouse events)
  • Reverts orbit rotation in screen space back to local plane space (includes fix for plane intersection at slight angles)
  • Local space transformation of multiple nodes uses last selected node

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

@kpal81xd kpal81xd self-assigned this Oct 28, 2025
@kpal81xd kpal81xd added the bug Something isn't working label Oct 28, 2025
@kpal81xd kpal81xd requested a review from a team October 28, 2025 12:28
@kpal81xd kpal81xd added the release: next patch Ticket marked for next patch release label Oct 28, 2025
@kpal81xd kpal81xd merged commit 61281f5 into main Oct 28, 2025
7 checks passed
@kpal81xd kpal81xd deleted the gizmos branch October 28, 2025 13:16
kpal81xd added a commit that referenced this pull request Oct 28, 2025
@kpal81xd
Gizmo regression fixes (#8079)
cdbedbe 
* fix: gizmo scale warping fixed on high FOV

* feat: add preventDefault flag for pointer events in Gizmo

* fix: reverted rotation to be in plane space and fixed slight angle rotations

* fix: use last selected node position when transforming in local space

* fix: apply angle flip before rotations are set

* fix: updated angle flip comment

* fix: moved angle flipping to inside calculate angle method
@karenbradish11-spec karenbradish11-spec mentioned this pull request Oct 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels

bug Something isn't working release: next patch Ticket marked for next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpal81xd @willeastcott