Patch null SOG entry #8056
Merged
Patch null SOG entry #8056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
added
bug
There was a problem hiding this comment.
Pull Request Overview
Fixes rendering failures by patching SOG codebooks that start with a null entry by computing a replacement value for index 0.
- Adds a patch for codebooks 'scales', 'sh0', and 'shN' when codebook[0] is null
- Leaves rest of generation flow unchanged
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
willeastcott
approved these changes
Oct 15, 2025
slimbuck
added a commit
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases scenes containing NaN or inf values can end up as
nullin one of the SOG codebook.In this case rendering fails and this PR fixes that.