Revert unintended change #8047
Merged
Revert unintended change #8047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR reverts an unintended change from PR #7999 that broke spherical harmonics functionality. The change simplifies the getProp method implementation by removing unnecessary variable assignments and type casting.
- Removes intermediate variable assignments in the
getPropmethod - Eliminates explicit type casting and fallback to empty Float32Array
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mvaligursky
approved these changes
Oct 10, 2025
slimbuck
added a commit
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert a change in #7999 which breaks spherical harmonics.
Fixes #8043