Skip to content

Conversation

@slimbuck
Copy link
Member

@slimbuck slimbuck commented Oct 7, 2025

Description

This PR fixes a long-standing issue with very bright gaussians showing a hard edge.

Also revert fastExp since it results in banding.

Before:

Screenshot 2025-10-07 at 13 14 26

After:

Screenshot 2025-10-07 at 13 14 29

@slimbuck slimbuck requested review from a team and Copilot October 7, 2025 13:44
@slimbuck slimbuck self-assigned this Oct 7, 2025
@slimbuck slimbuck added bug Something isn't working area: graphics Graphics related issue labels Oct 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes rendering artifacts in Gaussian splat rendering by addressing hard edges around very bright gaussians and reverting to native exponential functions to eliminate banding artifacts.

  • Removes custom fast exponential approximation that was causing banding
  • Implements a normalized alpha calculation to prevent hard edges on bright gaussians
  • Applies consistent fixes across both WGSL and GLSL shader implementations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/scene/shader-lib/wgsl/chunks/gsplat/frag/gsplat.js Updates WGSL fragment shader with normalized alpha calculation and removes fast exponential
src/scene/shader-lib/glsl/chunks/gsplat/frag/gsplat.js Updates GLSL fragment shader with normalized alpha calculation and removes fast exponential

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@slimbuck slimbuck merged commit 4e2cde3 into playcanvas:main Oct 7, 2025
6 of 7 checks passed
@slimbuck slimbuck deleted the gs-fix branch October 7, 2025 13:54
This was referenced Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Graphics related issue bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants