Skip to content

Conversation

@slimbuck
Copy link
Member

@slimbuck slimbuck commented Oct 1, 2025

Description

Update the bundled SOG loader to use the same asset interface as PLY.

User can provide URL, fetch request or arrayBuffer.

Also emit progress events like ply and unbundled SOG.

Fixes playcanvas/supersplat-viewer#66

@slimbuck slimbuck requested review from a team and Copilot October 1, 2025 15:26
@slimbuck slimbuck self-assigned this Oct 1, 2025
@slimbuck slimbuck added bug Something isn't working area: graphics Graphics related issue labels Oct 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the bundled SOG loader to support multiple input types (URL, fetch request, or ArrayBuffer) and adds progress event emission, aligning with the PLY loader's asset interface.

  • Refactored the load method to use async/await instead of callback-based asset fetching
  • Added downloadArrayBuffer function to handle different input types and emit progress events
  • Removed dependency on Asset.fetchArrayBuffer in favor of custom download logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@slimbuck slimbuck merged commit 426d9cc into playcanvas:main Oct 8, 2025
7 checks passed
@slimbuck slimbuck deleted the sog-dev branch October 8, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Graphics related issue bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First argument to DataView constructor must be an ArrayBuffer

2 participants