-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fixed min and mag filter for matrices texture #8013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed min and mag filter for matrices texture #8013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's unexpected as textureFetch should completely ignore sampler.
No harm though.
In that case lets add addressing as well
addressU: ADDRESS_CLAMP_TO_EDGE,
addressV: ADDRESS_CLAMP_TO_EDGE
I also thought that this would not affect, but when specifying filters, the example worked on my test phone. |
…m/AlexAPPi/engine into alex-fix-md-mp-example-tex-filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes texture filtering for matrices texture to resolve rendering issues on some devices. The change ensures that texture data is read correctly by disabling interpolation and clamping texture coordinates.
- Added nearest neighbor filtering (minFilter and magFilter) to prevent interpolation of matrix data
- Added clamp-to-edge addressing to prevent texture coordinate wrapping
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
That works on WebGL .. or does that fix WebGPU as well? |
I switched to WebGPU and rebooted my phone, now I get a black screen... |

Fixed min and mag filter for matrices texture.
Some devices were reading the texture incorrectly.