Fix: SOG proper removing of texture assets from asset cache #8012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a memory leak in SOG asset destruction by ensuring texture assets are properly removed from the AssetRegistry cache when GSplatSogsData is destroyed.
- Modified GSplatSogsData to accept and store texture asset references during construction
- Updated the destruction logic to call asset.unload() instead of directly destroying texture resources
- Updated both SogsParser and SogBundleParser to pass texture assets to GSplatSogsData constructor
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/scene/gsplat/gsplat-sogs-data.js | Added textureAssets property and constructor, modified _destroyGpuResources to unload assets properly |
| src/framework/parsers/sogs.js | Updated GSplatSogsData instantiation to pass textureAssets parameter |
| src/framework/parsers/sog-bundle.js | Updated GSplatSogsData instantiation to pass texture assets from bundle |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| this.sh_centroids?.destroy(); | ||
| this.sh_labels?.destroy(); | ||
|
|
||
| if(this.textureAssets) |
There was a problem hiding this comment.
[nitpick] Missing space after 'if' keyword. Should be 'if (this.textureAssets)' to follow JavaScript formatting conventions.
Suggested change
| if(this.textureAssets) | |
| if (this.textureAssets) |
Member
|
I think we only need |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a SOG asset is destroyed, GSplatSogsData.destroy() calls .destroy() directly on the texture resources. This fails to remove the parent Asset from the AssetRegistry cache.
Fixes #
Modify GSplatSogsData.destroy() to call asset.unload() on the texture Asset objects instead of destroying the resources directly.