Skip to content

Conversation

@kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Sep 17, 2025

Description

  • Limits render update event to only fire when the gizmo visually changes

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

@kpal81xd kpal81xd self-assigned this Sep 17, 2025
@kpal81xd kpal81xd added bug Something isn't working area: extras labels Sep 17, 2025
@kpal81xd kpal81xd requested a review from a team September 17, 2025 10:34
@kpal81xd kpal81xd added the release: next patch Ticket marked for next patch release label Sep 17, 2025
@kpal81xd kpal81xd merged commit 8191bc3 into main Sep 17, 2025
7 checks passed
@kpal81xd kpal81xd deleted the gizmos branch September 17, 2025 10:35
kpal81xd added a commit that referenced this pull request Sep 17, 2025
* Add internal facing direction tracking to RotateGizmo

* fix: only update position rotation and scale if enabled

* fix: replace direct render update calls with internal flag for efficiency

* fix: enable render updates in RotateGizmo after angle adjustment

* fix: add check for facing direction change in RotateGizmo

* fix: update comment to clarify purpose of internal facing direction vector

* fix: optimize shape visibility updates in ScaleGizmo and TranslateGizmo

* fix: optimize facing direction check in RotateGizmo to reduce unnecessary updates

* fix: move render update check to update method in Gizmo class
kpal81xd added a commit that referenced this pull request Sep 17, 2025
* Add internal facing direction tracking to RotateGizmo

* fix: only update position rotation and scale if enabled

* fix: replace direct render update calls with internal flag for efficiency

* fix: enable render updates in RotateGizmo after angle adjustment

* fix: add check for facing direction change in RotateGizmo

* fix: update comment to clarify purpose of internal facing direction vector

* fix: optimize shape visibility updates in ScaleGizmo and TranslateGizmo

* fix: optimize facing direction check in RotateGizmo to reduce unnecessary updates

* fix: move render update check to update method in Gizmo class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: extras bug Something isn't working release: next patch Ticket marked for next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants