Skip to content

Camera controls fixes #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 15, 2025
Merged

Camera controls fixes #7977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1305b03
fix: removed skip update since update skipped when script disabled
kpal81xd Sep 15, 2025
f6b7801
feat: add MobileInputLayout enum for improved input handling
kpal81xd Sep 15, 2025
e28012e
feat: reorganised attributes
kpal81xd Sep 15, 2025
6ede36e
feat: removed scene size
kpal81xd Sep 15, 2025
4c1b167
fix: loading default input layout
kpal81xd Sep 15, 2025
091585d
fix: update attribute title from Rotate Damping to Focus Damping
kpal81xd Sep 15, 2025
dc5633c
feat: update focus point attribute and reintroduce gamepad dead zone
kpal81xd Sep 15, 2025
a9ac14d
fix: updated move speed with sensibile defaults
kpal81xd Sep 15, 2025
24a998e
feat: add dynamic movement speeds based on scene size for camera cont…
kpal81xd Sep 15, 2025
17102c7
feat: adjust camera movement speeds based on scene size
kpal81xd Sep 15, 2025
92b72e5
fix: clarify comment for frame discard check in CameraControls
kpal81xd Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions examples/src/examples/camera/fly.example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,14 @@ camera.addComponent('script');
camera.setPosition(start);
app.root.addChild(camera);
const cc = /** @type { CameraControls} */ (camera.script.create(CameraControls));
const sceneSize = bbox.halfExtents.length();
Object.assign(cc, {
sceneSize: bbox.halfExtents.length(),
focusPoint: bbox.center,
enableOrbit: false,
enablePan: false
enablePan: false,
moveSpeed: 2 * sceneSize,
moveFastSpeed: 4 * sceneSize,
moveSlowSpeed: sceneSize
});

/**
Expand Down
7 changes: 5 additions & 2 deletions examples/src/examples/camera/multi.example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,12 @@ camera.addComponent('script');
camera.setPosition(start);
app.root.addChild(camera);
const cc = /** @type { CameraControls} */ (camera.script.create(CameraControls));
const sceneSize = bbox.halfExtents.length();
Object.assign(cc, {
sceneSize: bbox.halfExtents.length(),
focusPoint: bbox.center
focusPoint: bbox.center,
moveSpeed: 2 * sceneSize,
moveFastSpeed: 4 * sceneSize,
moveSlowSpeed: sceneSize
});

// focus on entity when 'f' key is pressed
Expand Down
7 changes: 5 additions & 2 deletions examples/src/examples/camera/orbit.example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,13 @@ camera.addComponent('script');
camera.setPosition(start);
app.root.addChild(camera);
const cc = /** @type { CameraControls} */ (camera.script.create(CameraControls));
const sceneSize = bbox.halfExtents.length();
Object.assign(cc, {
sceneSize: bbox.halfExtents.length(),
focusPoint: bbox.center,
enableFly: false
enableFly: false,
moveSpeed: 2 * sceneSize,
moveFastSpeed: 4 * sceneSize,
moveSlowSpeed: sceneSize
});

// focus on entity when 'f' key is pressed
Expand Down
5 changes: 3 additions & 2 deletions examples/src/examples/gaussian-splatting/lod-instances.example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,11 @@ assetListLoader.load(() => {

camera.addComponent('script');
const cc = /** @type { CameraControls} */ (camera.script.create(CameraControls));
const sceneSize = 500;
Object.assign(cc, {
sceneSize: 500,
moveSpeed: 0.003,
moveFastSpeed: 0.01,
moveSpeed: 0.003 * sceneSize,
moveFastSpeed: 0.01 * sceneSize,
enableOrbit: false,
enablePan: false,
focusPoint: new pc.Vec3(2, 0.6, 0)
Expand Down
10 changes: 5 additions & 5 deletions examples/src/examples/gaussian-splatting/lod.example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,12 @@ assetListLoader.load(() => {

camera.addComponent('script');
const cc = /** @type { CameraControls} */ (camera.script.create(CameraControls));
const sceneSize = 500;
Object.assign(cc, {
sceneSize: 500,
moveSpeed: 0.05,
moveFastSpeed: 0.3,
// moveSpeed: 0.005,
// moveFastSpeed: 0.03,
moveSpeed: 0.05 * sceneSize,
moveFastSpeed: 0.3 * sceneSize,
// moveSpeed: 0.005 * sceneSize,
// moveFastSpeed: 0.03 * sceneSize,
enableOrbit: false,
enablePan: false
});
Expand Down
2 changes: 1 addition & 1 deletion examples/src/examples/misc/editor.example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ Object.assign(cc, {
moveDamping: 0
});
app.on('gizmo:pointer', (/** @type {boolean} */ hasPointer) => {
cc.skipUpdate = hasPointer;
cc.enabled = !hasPointer;
});

// outline renderer
Expand Down
Loading