Skip to content

Fixed rotation from negatively scaled transform #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

Fixed rotation from negatively scaled transform #7976

merged 2 commits into from
Sep 15, 2025

Conversation

@kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Sep 15, 2025 •
edited
Loading

Description

  • Fixes setting rotation from transformation matrix by checking if its 'handness` has been flipped by negative scale. Flipping X axis will restore 'handness' to rhs

Fixes #5135
Fixes #7909

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

@kpal81xd kpal81xd self-assigned this Sep 15, 2025
@kpal81xd kpal81xd added the bug Something isn't working label Sep 15, 2025
@kpal81xd kpal81xd merged commit 612add9 into main Sep 15, 2025
7 checks passed
@kpal81xd kpal81xd deleted the neg-scale-rot branch September 15, 2025 13:37
kpal81xd added a commit that referenced this pull request Sep 15, 2025
@kpal81xd
fix: fixes space parity when setting rotation from matrix (#7976)
071f9aa
kpal81xd added a commit that referenced this pull request Sep 17, 2025
@kpal81xd
fix: fixes space parity when setting rotation from matrix (#7976)
0d38706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willeastcott willeastcott willeastcott approved these changes

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@kpal81xd kpal81xd

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rotation resets to previous value when scale is inverted getRotation does not calculate the rotation correctly if the parent has a negative scale

4 participants

@kpal81xd @willeastcott @mvaligursky