Fix SH bug on SOG import #7972
Merged
Fix SH bug on SOG import #7972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in spherical harmonic data extraction for SOG (Splat on Geometry) scenes with 1 or 2 bands instead of the previously hardcoded 3 bands. The fix dynamically calculates the number of spherical harmonic coefficients based on the actual number of bands in the data.
- Extracts
shBandsfrom the data object to determine the correct number of bands - Replaces hardcoded coefficient count of 15 with dynamic calculation based on band count
- Updates loop iterations to use the calculated coefficient count instead of fixed value
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
willeastcott
approved these changes
Sep 13, 2025
slimbuck
added a commit
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: playcanvas/splat-transform#52
Description
Spherical harmonic data was being wrongly extracted for SOG scenes with 1 or 2 bands:
This is now fixed:
