Skip to content

Gizmo fixes #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 8, 2025
Merged

Gizmo fixes #7956

merged 5 commits into from
Sep 8, 2025

Conversation

@kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Sep 8, 2025 •
edited
Loading

Fixes

  • Discard fragment if alpha too low (< 1/255)
  • Visibility state check early return
  • Skip scale axis mirror if flip axis flag disabled

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

@kpal81xd kpal81xd self-assigned this Sep 8, 2025
@kpal81xd kpal81xd added the bug Something isn't working label Sep 8, 2025
@kpal81xd kpal81xd requested review from a team and mvaligursky September 8, 2025 13:40
@kpal81xd kpal81xd changed the title Gizmo shape fixes Gizmo fixes Sep 8, 2025
mvaligursky
mvaligursky reviewed Sep 8, 2025
View reviewed changes
@kpal81xd kpal81xd merged commit 24ca7b3 into main Sep 8, 2025
7 checks passed
@kpal81xd kpal81xd deleted the gizmo branch September 8, 2025 13:52
kpal81xd added a commit that referenced this pull request Sep 8, 2025
@kpal81xd
Gizmo fixes (#7956)
02bd060 
* fix: correct alpha channel usage in fragment color output

* fix: optimize visibility setter to prevent unnecessary updates

* fix: add alpha channel check to discard transparent fragments in unlit shader

* fix: update alpha channel threshold for fragment discard in unlit shader

* fix: add axis flipping functionality in ScaleGizmo based on camera direction
@kpal81xd kpal81xd mentioned this pull request Sep 9, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@kpal81xd kpal81xd

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpal81xd @mvaligursky