Skip to content

Conversation

@kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Sep 5, 2025

Description

  • Splits npm publish and code.playcanvas.com upload workflows

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

@kpal81xd kpal81xd self-assigned this Sep 5, 2025
@kpal81xd kpal81xd requested a review from Copilot September 5, 2025 12:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Splits the npm publish and code.playcanvas.com upload workflows into separate jobs for better separation of concerns and workflow organization.

  • Moves the code.playcanvas.com upload logic from the publish workflow to a new dedicated upload workflow
  • Changes the repository condition from github.repository to github.repository_owner for consistency
  • Implements artifact-based communication between workflows using version.txt file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/upload.yaml New workflow for uploading to code.playcanvas.com that triggers after the publish workflow completes
.github/workflows/publish.yaml Modified to remove upload logic and add version artifact creation for the upload workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kpal81xd kpal81xd merged commit 38071bb into main Sep 5, 2025
6 of 7 checks passed
@kpal81xd kpal81xd deleted the ci branch September 5, 2025 12:49
kpal81xd added a commit that referenced this pull request Sep 5, 2025
* fix: separated out the code.playcanvas.com upload into separate workflow

* Update .github/workflows/upload.yaml

Co-authored-by: Copilot <[email protected]>

* fix: clean up workflow configuration in upload.yaml

---------

Co-authored-by: Copilot <[email protected]>
kpal81xd added a commit that referenced this pull request Sep 5, 2025
* fix: separated out the code.playcanvas.com upload into separate workflow

* Update .github/workflows/upload.yaml

Co-authored-by: Copilot <[email protected]>

* fix: clean up workflow configuration in upload.yaml

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants