-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Release script update #7663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release script update #7663
Conversation
…ing in release script
…nd improve version calculation logic
… in release script
…re-release versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the release process by replacing the Node.js script with a Bash script, adjusting version formats, and extending the CI workflow to handle preview releases and upload to code.playcanvas.com.
- Adds
release.shfor branch- and tag-based releases, removesrelease.cjs - Adjusts
package.jsondev version to include.0 - Updates
publish.yamlto supportpreviewprerelease tags and a new upload step
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| release.sh | New Bash-based release script handling branch creation and finalization |
| release.cjs | Entirely removed old Node.js release script |
| package.json | Bump dev version from "2.8.0-dev" to "2.8.0-dev.0" |
| .github/workflows/publish.yaml | Add preview tag pattern, publish step branching, and upload to API |
Comments suppressed due to low confidence (1)
release.sh:9
- The dot in the version regex is not escaped, so it matches any character. Escape it (e.g.,
\.) to ensure it only matches the literal period.
RELEASE_REGEX="^$RELEASE_PREFIX[0-9]+.[0-9]+$"
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the release process by replacing the Node‐based script with a Bash script and adjusting the release versioning and publishing workflows. Key changes include:
- Introducing a Bash-based release script (release.sh) while removing the previous release.cjs.
- Updating version formatting in package.json.
- Enhancing the publish workflow (.github/workflows/publish.yaml) to handle preview releases and add a step for publishing to code.playcanvas.com.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| release.sh | New Bash release script to create and finalize releases using npm version commands. |
| release.cjs | Removal of the legacy Node-based release script. |
| package.json | Updated version field to include a build segment. |
| .github/workflows/publish.yaml | Adjusted tag parsing and publishing logic to support the preview prerelease tag and publish step. |
Comments suppressed due to low confidence (1)
package.json:3
- [nitpick] The updated version format now includes an additional build segment ('.0'); ensure that related versioning documentation and downstream tooling are updated accordingly.
"version": "2.8.0-dev.0",
Co-authored-by: Copilot <[email protected]>
* removed dev from version * Add CommonJS support to ESLint config and improve console log formatting in release script * WIP: release script updated version * Fix release script to use current branch name and improve branch handling logic * Simplify finalization prompt in release script by removing tag existence check * Add git fetch command to ensure remote tags are available before finalizing release * Refactor condition check for branch type in release script * Add comments to clarify branch checks in release script * Normalize prompt responses in release script for consistency * Changed main branch to main * Enhance help message and usage instructions in release script * Add comment to clarify release type determination in release script * Update prompt message for finalizing release to include release type * Refactor release script to improve prompt message and ensure prerelease tagging * Refactor release script to use variables for prerelease identifiers and improve version calculation logic * Add checks for uncommitted changes and streamline version calculation in release script * Update publish workflow to use 'preview' tag instead of 'alpha' for pre-release versions * Remove npm version command from pre-release tag detection in publish workflow * Add publishing step to code.playcanvas.com in workflow * Fix engine version variable in PlayCanvas publish step * Refactor tag parsing and publishing logic in workflow * Fix tag condition in npm publish step to use regex for preview detection * Add silent flag to curl command for PlayCanvas publishing step * Fix curl command in PlayCanvas publishing step to handle errors * Remove deprecated CommonJS configuration and release script * fix: Update PlayCanvas publish endpoint to use secret variable * Update .github/workflows/publish.yaml Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* removed dev from version * Add CommonJS support to ESLint config and improve console log formatting in release script * WIP: release script updated version * Fix release script to use current branch name and improve branch handling logic * Simplify finalization prompt in release script by removing tag existence check * Add git fetch command to ensure remote tags are available before finalizing release * Refactor condition check for branch type in release script * Add comments to clarify branch checks in release script * Normalize prompt responses in release script for consistency * Changed main branch to main * Enhance help message and usage instructions in release script * Add comment to clarify release type determination in release script * Update prompt message for finalizing release to include release type * Refactor release script to improve prompt message and ensure prerelease tagging * Refactor release script to use variables for prerelease identifiers and improve version calculation logic * Add checks for uncommitted changes and streamline version calculation in release script * Update publish workflow to use 'preview' tag instead of 'alpha' for pre-release versions * Remove npm version command from pre-release tag detection in publish workflow * Add publishing step to code.playcanvas.com in workflow * Fix engine version variable in PlayCanvas publish step * Refactor tag parsing and publishing logic in workflow * Fix tag condition in npm publish step to use regex for preview detection * Add silent flag to curl command for PlayCanvas publishing step * Fix curl command in PlayCanvas publishing step to handle errors * Remove deprecated CommonJS configuration and release script * fix: Update PlayCanvas publish endpoint to use secret variable * Update .github/workflows/publish.yaml Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* removed dev from version * Add CommonJS support to ESLint config and improve console log formatting in release script * WIP: release script updated version * Fix release script to use current branch name and improve branch handling logic * Simplify finalization prompt in release script by removing tag existence check * Add git fetch command to ensure remote tags are available before finalizing release * Refactor condition check for branch type in release script * Add comments to clarify branch checks in release script * Normalize prompt responses in release script for consistency * Changed main branch to main * Enhance help message and usage instructions in release script * Add comment to clarify release type determination in release script * Update prompt message for finalizing release to include release type * Refactor release script to improve prompt message and ensure prerelease tagging * Refactor release script to use variables for prerelease identifiers and improve version calculation logic * Add checks for uncommitted changes and streamline version calculation in release script * Update publish workflow to use 'preview' tag instead of 'alpha' for pre-release versions * Remove npm version command from pre-release tag detection in publish workflow * Add publishing step to code.playcanvas.com in workflow * Fix engine version variable in PlayCanvas publish step * Refactor tag parsing and publishing logic in workflow * Fix tag condition in npm publish step to use regex for preview detection * Add silent flag to curl command for PlayCanvas publishing step * Fix curl command in PlayCanvas publishing step to handle errors * Remove deprecated CommonJS configuration and release script * fix: Update PlayCanvas publish endpoint to use secret variable * Update .github/workflows/publish.yaml Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> * Update release.sh Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Overview
npm versioncommand to create and update versions with and without taggingpublish.yamlto use prerelease tagpreviewand adds step to upload to code.playcanvas.comTesting
Post Merge
release-2.7main_v1release-1.77