Skip to content

Conversation

@mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented May 1, 2025

The Asset class had both id and _id members, and in #7517 the _id had been removed.

Unfortunately the tags class still used it, and tagging stoped working. This makes tags use id.

@mvaligursky mvaligursky self-assigned this May 1, 2025
@mvaligursky mvaligursky added bug Something isn't working area: assets labels May 1, 2025
@mvaligursky mvaligursky requested a review from a team May 1, 2025 12:44
@Maksims
Copy link
Collaborator

Maksims commented May 1, 2025

The hot-fix in the meantime:

Object.defineProperty(pc.Asset.prototype, '_id', {
    get: function () {
        return this.id;
    },
    set: function (value) {
        this.id = value;
    }
});

@mvaligursky mvaligursky merged commit db56e5c into main May 1, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-asset-tags-fix branch May 1, 2025 12:48
mvaligursky added a commit that referenced this pull request May 1, 2025
Co-authored-by: Martin Valigursky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: assets bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants