Skip to content

Conversation

@willeastcott
Copy link
Contributor

It seems EVENT_END was documented on the SoundComponent but not SoundSlot.

Fixes #5076

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott added bug Something isn't working docs Documentation related area: audio labels May 1, 2025
@willeastcott willeastcott requested a review from Copilot May 1, 2025 00:35
@willeastcott willeastcott self-assigned this May 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing documentation for the SoundSlot.EVENT_END event, ensuring consistency with similar events in the SoundComponent.

  • Adds a new documentation block describing the EVENT_END event and its usage
  • Enhances code documentation consistency between related components

@willeastcott willeastcott requested a review from mvaligursky May 1, 2025 19:48
@willeastcott willeastcott merged commit 43d0ee2 into main May 1, 2025
7 checks passed
@willeastcott willeastcott deleted the slot-end-docs branch May 1, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: audio bug Something isn't working docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add audio stop event

3 participants