Gsplat render fix for wgpu #7609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
added
bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the Gaussian splat shader rendering for WebGPU by adjusting the z clipping range to account for WebGPU’s clip-space (0..1) as opposed to WebGL’s (-1..1).
- Updates z clipping clamp values using a preprocessor directive for WEBGPU
- Retains the existing behavior for WebGL using a conditional compilation branch
Comments suppressed due to low confidence (1)
src/scene/shader-lib/chunks/gsplat/vert/gsplatCenter.js:19
- Consider adding tests to verify that the shader behaves correctly with the updated z clipping configuration for both WEBGPU and WebGL, ensuring that the intended behavior is maintained.
#if WEBGPU
mvaligursky
approved these changes
Apr 25, 2025
slimbuck
added a commit
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for gaussian splats on webgpu.
Webgpu uses z clip range of 0..1, unlike webgl which uses range -1..1.