-
Notifications
You must be signed in to change notification settings - Fork 105
feat(inspector): Add preview for templates in the inspector #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One significant think to look at, is that shader compilation is inevitable in this case. And it can be of serious problem in projects with more complex setups and combinations of materials. To avoid that, we would need to ensure not too many thumbnails are ever attempted to be rendered in a single frame. |
|
@abstrakt8 With Engine 2.12.x released, I guess this can be merged now? |
|
Still looks good after merging in from main |
kpal81xd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with couple of comments
What has changed?
TemplatePreview.mp4
TemplatePreview.reactive.mp4
Implementation details
Dependencies
Not in scope
editor/src/common/pcui/element/element-asset-thumbnail.ts
Line 29 in 793d204