Skip to content

Conversation

@abstrakt8
Copy link
Contributor

@abstrakt8 abstrakt8 commented Sep 25, 2025

What has changed?

TemplatePreview.mp4
TemplatePreview.reactive.mp4
NoPreviewAvailable

Implementation details

  • Takes into account that entities that are not enabled in the hierarchy are also not rendered.
  • Watching for material changes (because they are not part of the template)
  • Watching for template changes (had to do an engine fix)
  • Display a text "No preview available" if no mesh instances were found.

Dependencies

Not in scope

@Maksims
Copy link
Collaborator

Maksims commented Sep 25, 2025

One significant think to look at, is that shader compilation is inevitable in this case. And it can be of serious problem in projects with more complex setups and combinations of materials.
We already have a problem where navigating to a folder with 10 materials, freezes browser for 5+ seconds.

To avoid that, we would need to ensure not too many thumbnails are ever attempted to be rendered in a single frame.

@abstrakt8 abstrakt8 marked this pull request as ready for review September 29, 2025 12:21
@abstrakt8 abstrakt8 requested a review from kpal81xd September 29, 2025 12:21
@willeastcott
Copy link
Contributor

@abstrakt8 With Engine 2.12.x released, I guess this can be merged now?

@abstrakt8
Copy link
Contributor Author

Still looks good after merging in from main

Copy link
Contributor

@kpal81xd kpal81xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with couple of comments

@abstrakt8 abstrakt8 merged commit 6ace773 into main Nov 3, 2025
3 checks passed
@abstrakt8 abstrakt8 deleted the template-preview-5 branch November 3, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Previewing Templates

5 participants