Adds scriptName to ESM template #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESM Scripts now require a `scriptName` field. See playcanvas/engine#7593 This updates the boiler plate to include this new field.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the ESM script boilerplate by adding a new static field, scriptName, to comply with the updated engine requirements.
- Added a static scriptName field in two locations within the create-script.ts file
- Ensured the new field is introduced in both class declarations to match the new standard
mvaligursky
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM Scripts now require a
scriptNamefield. See playcanvas/engine#7593This updates the boiler plate to include this new field.