Allow dependabot to push ncc build commits to it's own branches#38
Merged
Allow dependabot to push ncc build commits to it's own branches#38
Conversation
The ncc workflow from balto-utils will build and attempt to push the build commit to the branch it was ran on. When dependabot opens a security update PR, it needs to re-run the build as well. The build runs just fine, but the default permissions for Github workflows prevent it from being able to push up the commit. Let's change that for just this workflow. Because we have full control over the ncc action (it's our own typescript action, in our own utils repo), I'm less worried about issues here. The alternative to doing this would be to manually build a push up a commit for each dependabot PR. That doesn't seem like a _huge_ lift as this is one of the first dependabot PRs since the v1 release, but as this is no ones full time focus, I'd like to optimize for ease of maintainability and make it easier to get security releases out faster.
danielma
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ncc workflow from balto-utils will build and attempt to push the build commit to the branch it was ran on. When dependabot opens a security update PR, it needs to re-run the build as well. The build runs just fine, but the default permissions for Github workflows prevent it from being able to push up the commit. Let's change that for just this workflow.
Because we have full control over the ncc action (it's our own typescript action, in our own utils repo), I'm less worried about issues here.
The alternative to doing this would be to manually build a push up a commit for each dependabot PR. That doesn't seem like a huge lift as this is one of the first dependabot PRs since the v1 release, but as this is no ones full time focus, I'd like to optimize for ease of maintainability and make it easier to get security releases out faster.