fix: prevent CodeMirror measure loop by limiting view.setState to file changes #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinoksb
commented
Dec 9, 2025
dinoksb
commented
- Ensure the editor re-renders correctly when the document's filePath or editable state changes
added 3 commits
December 9, 2025 17:49
…and editable - Ensure the editor re-renders correctly when the document's filePath or editable state changes
…value - Ensure the editor re-renders correctly when the document's value changes, in addition to filePath and editable state
- Introduce a check to detect changes in the file path before applying the editor state - Ensure the editor state is only updated when the file path has changed, improving performance and reducing unnecessary renders
added 3 commits
December 10, 2025 16:43
…ling - Remove unnecessary comments and consolidate type definitions for clarity. - Update transaction handling to use a more consistent dispatch method. - Simplify document update logic and state management, ensuring proper handling of editor states and selections. - Enhance error handling during document and theme updates to improve robustness.
- Remove outdated and redundant messages related to view availability during layout and language loading. - Streamline the error messages to enhance clarity and maintainability.
- Simplify the logic for checking view availability and update the method of handling editor view references. - Consolidate the editor view recreation process to enhance clarity and maintainability. - Streamline the document update logic by removing unnecessary checks and ensuring proper state restoration. - Enhance error handling during view recreation to provide fallback mechanisms when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.