Skip to content

Conversation

@FioX0
Copy link

@FioX0 FioX0 commented Oct 20, 2025

While there is an endpoint for rankings for when the season ends.

There has been a very big demand from the community to be able to get ranking from the on-going season.
As targets are selected randomly, there shouldn't be any downsides of making the on-going rankings public.

This pull request would allow someone to pull the on-going rankings, or observe previous rounds rankings by using:
http://localhost:5025/leaderboard/participants?seasonId=23&roundId=38

Which would return a sample result of:

[ { "agentAddress": "cf1270e34b683fb42c9c4339e2a72c3d474f8db4", "avatarAddress": "cf1270e34b683fb42c9c4339e2a72c3d474f8db4", "nameWithHash": "Triplexmazi <size=80%><color=#A68F7E>#cf12</color></size>", "level": 415, "cp": 90566268, "score": 1001 }, { "agentAddress": "d9186d0a270b8ac77407602e198c6bb21db0ac4e", "avatarAddress": "d9186d0a270b8ac77407602e198c6bb21db0ac4e", "nameWithHash": "Satan <size=80%><color=#A68F7E>#d918</color></size>", "level": 414, "cp": 101383775, "score": 1000 }, { "agentAddress": "f9cd29951b3addce2a926955ef22a846fd8b1d06", "avatarAddress": "f9cd29951b3addce2a926955ef22a846fd8b1d06", "nameWithHash": "Harem <size=80%><color=#A68F7E>#f9CD</color></size>", "level": 413, "cp": 49502374, "score": 1000 }, { "agentAddress": "a9843fa08fe952d74b602c29bcab08e2ad7664d3", "avatarAddress": "a9843fa08fe952d74b602c29bcab08e2ad7664d3", "nameWithHash": "Deus <size=80%><color=#A68F7E>#a984</color></size>", "level": 406, "cp": 25282464, "score": 1000 } ]

@Atralupus
Copy link
Member

Related to #50

@Atralupus
Copy link
Member

Thank you for the PR. I’ll be on vacation, so I’ll be able to review it after November.
I’ll take a look and give you feedback when I’m back.
In the meantime, please check only the failing tests.

@ipdae
Copy link
Member

ipdae commented Oct 21, 2025

@FioX0 test is broken. can you fix it?

@FioX0
Copy link
Author

FioX0 commented Oct 30, 2025

Added pagination, as per initial suggestion #50

Also resolved the TEST failure, and added a specific test for this new endpoint. I tried to maintain the same structure and commenting style as the previous endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants