Fix broken tracing with multiple layers#660
Merged
Merged
Conversation
soundofspace
force-pushed
the
fix-broken-tracing-with-multiple-layers
branch
from
2e11ac3 to
83d7c7f
Compare
GlenDC
requested changes
Aug 19, 2025
GlenDC
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracing doesn't really support trace events inside Debug implementations. This debug impl has a trace event quite deep in the debug logic. Easy option is to remove that trace event in
SettingOrder::pushbut to me this shows that this Debug impl was too complex, so I simplified it. It should still contain all the necessary info, just a bit more manual when you need to interpret it