Issue 498/support auto proxy connector http+https+socks5+socks5h#659
Merged
soundofspace merged 13 commits intoAug 9, 2025
Merged
Conversation
041802f to
6679262
Compare
GlenDC
requested changes
Aug 7, 2025
GlenDC
left a comment
Member
There was a problem hiding this comment.
Looks good. Only have some minor / nitpick comments. I would still like these to be resolved, but the work is excellent. Thanks a lot! Wonderful addition.
Only thing I see missing here that I would have still expected to be in scope for this PR is that you did not remove yet the manual clients in socks5 tests where now you can just use the regular runner client that is part of the example utils. Right?
GlenDC
approved these changes
Aug 8, 2025
GlenDC
left a comment
Member
There was a problem hiding this comment.
LGTM, couple of last remarks but these are details that you can probably resolve without any controversy and merge it yourself afterwards if you have the confidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optionalmode which forwards traffic to inner one if proxy is not configured. I could have modified this to also forward traffic to inner svc if Proxy protocol was wrong instead of returning error like we do now, but this felt ugly and error prone in the long run