Add geometry collection support for contains#13
Open
kaaboaye wants to merge 1 commit intopkinney:masterfrom
Open
Add geometry collection support for contains#13kaaboaye wants to merge 1 commit intopkinney:masterfrom
kaaboaye wants to merge 1 commit intopkinney:masterfrom
Conversation
Owner
|
@kaaboaye This is a great addition, thank you. It makes sense to add this in as it completes the coverage of the types available in the Geo package. Before we merge it in, I think it should probably be added to all of the other operations at the same time and probably needs a bit of testing and documentation around it as well if you are up for it. |
Author
|
Sure
I’ll take care of this
… On 12 Sep 2019, at 04:51, Powell Kinney ***@***.***> wrote:
@kaaboaye This is a great addition, thank you. It makes sense to add this in as it completes the coverage of the types available in the Geo package.
Before we merge it in, I think it should probably be added to all of the other operations at the same time and probably needs a bit of testing and documentation around it as well if you are up for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables contains check for
Geo.GeometryCollectionExample: