Do not erase decoded video frame in on_rx_rtp#4398
Closed
half-left wants to merge 1 commit intopjsip:masterfrom
Closed
Do not erase decoded video frame in on_rx_rtp#4398half-left wants to merge 1 commit intopjsip:masterfrom
half-left wants to merge 1 commit intopjsip:masterfrom
Conversation
Stream can try to decode another on due to ts diff greater than stream dec_max_delay, but it can be unsucsessful, so it should restore already decoded frame
Contributor
Author
|
sorry, it's already solved in 078bfea |
Contributor
|
Seems to be implemented in #4325 @nanangizz do you have any estimates in which release will it be incorporated? That PR has no milestone unfortunately.. |
Member
Oops, forgot to set the milestone, it should be 2.16, thanks for catching that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream can try to decode another on due to ts_diff greater than
stream->dec_max_delay,but it can be unsucsessful because offrm_cnt < stream->dec_delay_cnt, so it should restore already decoded frame