Skip to content

Signed-off-by: Pesala Silva <pesala.silva@ifs.com>Media-Port-Changes-for-call-record-and-play-feature#4366

Closed
PesalaDeSilva wants to merge 1 commit intopjsip:masterfrom
PesalaDeSilva:media-port-changes-for-PJSIP-2.13
Closed

Signed-off-by: Pesala Silva <pesala.silva@ifs.com>Media-Port-Changes-for-call-record-and-play-feature#4366
PesalaDeSilva wants to merge 1 commit intopjsip:masterfrom
PesalaDeSilva:media-port-changes-for-PJSIP-2.13

Conversation

@PesalaDeSilva
Copy link
Copy Markdown
Contributor

@PesalaDeSilva PesalaDeSilva commented Mar 20, 2025

Media-Port-Changes-for-call-record-and-play-feature

@sauwming
Copy link
Copy Markdown
Member

In my opinion, adding memory player&recorder to pjsua API doesn't appear very appealing. Yes, it can prove to be useful for some who require the feature, but considering the rather extensive modifications required and the very specific purpose it serves, I'm more inclined not to integrate this.

My recommendation is to move the implementation into the application level, as separate files from the PJSIP library. This way, you don't need to modify PJSIP library, and you won't be affected if there's a PJSIP version upgrade.

But first I would invite my other team to review this, perhaps they have a different opinion.

@nanangizz
Copy link
Copy Markdown
Member

IMO the pjmedia ports should not be implemented inside PJSUA-LIB.

Btw, there are already memory player & writer ports in PJMEDIA. As other pjmedia ports, application can use & manage them directly without PJSUA-LIB.

@sauwming
Copy link
Copy Markdown
Member

Thank you for the PR but our apologies that we can't accept this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants