Signed-off-by: Pesala Silva <pesala.silva@ifs.com>Media-Port-Changes-for-call-record-and-play-feature#4366
Conversation
…for-call-record-and-play-feature
|
In my opinion, adding memory player&recorder to pjsua API doesn't appear very appealing. Yes, it can prove to be useful for some who require the feature, but considering the rather extensive modifications required and the very specific purpose it serves, I'm more inclined not to integrate this. My recommendation is to move the implementation into the application level, as separate files from the PJSIP library. This way, you don't need to modify PJSIP library, and you won't be affected if there's a PJSIP version upgrade. But first I would invite my other team to review this, perhaps they have a different opinion. |
|
IMO the pjmedia ports should not be implemented inside PJSUA-LIB. Btw, there are already memory player & writer ports in PJMEDIA. As other pjmedia ports, application can use & manage them directly without PJSUA-LIB. |
|
Thank you for the PR but our apologies that we can't accept this at the moment. |
Media-Port-Changes-for-call-record-and-play-feature