Fix IOCP: key destroy handler not called when app supplies group lock#4355
Merged
Fix IOCP: key destroy handler not called when app supplies group lock#4355
Conversation
sauwming
approved these changes
Mar 14, 2025
BarryYin
pushed a commit
to BarryYin/pjproject
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4136, group lock has been integrated into IOCP. When quitting pjsua app, IOCP destroy always blocks (for ~5 seconds) and there is log indicating some ioqueue keys are not released properly:
After investigation, the unreleased key's group lock reference counter actually reaches zero, but the destructor is not invoked. It turns out that when an ioqueue key is registered with group lock supplied by app, the key destroy handler is not added to the group lock. Currently SIP transports & media transports register their ioqueue keys with group lock.