Skip to content

Fix the info_cnt of pjsip_dlg_event_status when parsing dialog info #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanangizz merged 1 commit into from
Dec 16, 2024
Merged

Fix the info_cnt of pjsip_dlg_event_status when parsing dialog info #4214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pjsip/include/pjsip-simple/dlg_event.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ PJ_DECL(pjsip_module*) pjsip_bdlg_event_instance(void);
* Maximum dialog event status info items which can handled by application.
*
*/
#define PJSIP_DLG_EVENT_STATUS_MAX_INFO 8
#define PJSIP_DLG_EVENT_STATUS_MAX_INFO 1


/**
Expand Down
4 changes: 2 additions & 2 deletions pjsip/src/pjsip-simple/dlg_event.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,11 @@ pjsip_dlg_event_parse_dialog_info2(char *body, unsigned body_len,
pjsip_dlg_info_dialog_info *dialog_info;
pjsip_dlg_info_dialog *dialog;

dlgev_st->info_cnt = 0;
dialog_info = pjsip_dlg_info_parse(pool, body, body_len);
if (dialog_info == NULL)
return PJSIP_SIMPLE_EBADPIDF;

dlgev_st->info_cnt = 0;

dialog = pjsip_dlg_info_dialog_info_get_dialog(dialog_info);
pj_strdup(pool, &dlgev_st->info[dlgev_st->info_cnt].dialog_info_entity,
pjsip_dlg_info_dialog_info_get_entity(dialog_info));
Expand Down Expand Up @@ -402,6 +401,7 @@ pjsip_dlg_event_parse_dialog_info2(char *body, unsigned body_len,
} else {
dlgev_st->info[dlgev_st->info_cnt].dialog_node = NULL;
}
dlgev_st->info_cnt++;

return PJ_SUCCESS;
}
Expand Down