Skip to content

Fixed bug in audio conference disconnection#4198

Merged
sauwming merged 1 commit intomasterfrom
conf-disc
Dec 6, 2024
Merged

Fixed bug in audio conference disconnection#4198
sauwming merged 1 commit intomasterfrom
conf-disc

Conversation

@sauwming
Copy link
Copy Markdown
Member

@sauwming sauwming commented Dec 6, 2024

To fix #4196.

Related to #3928, the loops to disconnect multiple connections from audio ports (any->sink, or source->any) are incorrect due to the potentially changing listener array and its count.

        for (i=0; i<src_port->listener_cnt; ++i) {
            ...
            // But the listener count will decrease here, and its array will shift.
            op_disconnect_ports(conf, &op_prm);
        }

@sauwming sauwming requested a review from nanangizz December 6, 2024 07:20
@sauwming sauwming self-assigned this Dec 6, 2024
@sauwming sauwming added this to the release-2.16 milestone Dec 6, 2024
@sauwming sauwming merged commit 9030274 into master Dec 6, 2024
@sauwming sauwming deleted the conf-disc branch December 6, 2024 08:35
BarryYin pushed a commit to BarryYin/pjproject that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio streaming to audio sink does not stop after ending call

2 participants