Fix stream lingering issues due to using transport's group lock#4184
Merged
Fix stream lingering issues due to using transport's group lock#4184
Conversation
Member
Author
|
Tested with both scenarios: #3956 & #3970 (comment), looks fine. |
…nd something after returning from callback which destroys the stream.
sauwming
reviewed
Nov 29, 2024
trengginas
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #3970 (comment) by using its own group lock instead of transport's group lock.
Also, maintain ref to transport just in case stream still tries to send something after returning from callback which has just destroyed the stream.