Removed unnecessary prechecks in async conference bridge operations#4121
Merged
Removed unnecessary prechecks in async conference bridge operations#4121
Conversation
sauwming
approved these changes
Oct 30, 2024
trengginas
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #3928, reported that when connecting & disconnecting ports requests are issued in a very short interval (e.g: when auto answer with resp code 200 is enabled in pjsua app), the disconnect request may fail which cause the ports to remain connected (undesirable). The failure in disconnection request happens because there is precheck of connection availability. Those prechecks are still be performed in the operation execution, but not in the operation request. This PR will remove such prechecks in all async operations requests.
This PR also contain some minor updates, e.g:
on_returnlabel to clean up error handling.