Skip to content

Support Push Notification in iOS sample app#3913

Merged
sauwming merged 3 commits intomasterfrom
ios-push
Apr 23, 2024
Merged

Support Push Notification in iOS sample app#3913
sauwming merged 3 commits intomasterfrom
ios-push

Conversation

@sauwming
Copy link
Copy Markdown
Member

@sauwming sauwming commented Apr 4, 2024 •
edited
Loading

Provide an example on how to implement Push Notification using PushKit and CallKit frameworks in ipjsua sample app.

Also in this PR:
Add sample on how to call PJSIP functions from a PJLIB registered thread via timer.

@sauwming sauwming self-assigned this Apr 4, 2024
@sauwming sauwming added this to the release-2.15 milestone Apr 4, 2024
@sauwming sauwming requested a review from trengginas April 5, 2024 06:06
@sauwming sauwming requested a review from nanangizz April 15, 2024 01:52
@nanangizz
Copy link
Copy Markdown
Member

nanangizz commented Apr 17, 2024

Is two/more incoming calls scenario handled, e.g:

  • concurrently, user may want to choose which call to answer, or
  • another incoming call in the middle of an active call.

@sauwming
Copy link
Copy Markdown
Member Author

sauwming commented Apr 18, 2024

Ah right, currently it's not handled yet.
I will add this to the implementation.

@sauwming
Copy link
Copy Markdown
Member Author

sauwming commented Apr 19, 2024

Is two/more incoming calls scenario handled, e.g:

  • concurrently, user may want to choose which call to answer, or
  • another incoming call in the middle of an active call.

Done.

nanangizz
nanangizz approved these changes Apr 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@nanangizz nanangizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

Btw, the patch seems to also add sample code of how to call PJSIP functions from a PJLIB registered thread via timer, perhaps add desc about this too?

@sauwming sauwming merged commit 472bda5 into master Apr 23, 2024
@sauwming sauwming deleted the ios-push branch April 23, 2024 04:59
dshamaev-intermedia added a commit to intermedia-net/pjproject that referenced this pull request Jun 12, 2024
@github-actions @naf419
@goodicus @amubiera @xhit @sauwming @nanangizz @dshamaev-intermedia @pespin @trengginas @peldszus
Automated Pull Request (#86)
e9b9e72 
* Add missing openssl SECLEVEL=0 support (pjsip#3890)

Previous SECLEVEL support allowed for levels 1-5.
However, openssl defines levels 0-5. [1]

Recent openssl versions (3.0+) have moved previous
popular ciphers/key lengths (i.e. RSA1024withSHA1)
into level 0, so it is now a reasonable choice to use.

Add support for level 0.

[1] https://www.openssl.org/docs/man3.2/man3/SSL_CTX_set_security_level.html

* Enable Late Offer Answer Mode (LOAM) feature in the pjsua (pjsip#3869)

* Fix warnings for 32-bit compiler and misc fixes. (pjsip#3896)

* Add some missing unlocks (pjsip#3893)

* Prevent race condition in DTLS media stop (pjsip#3901)

* Fix data race reported by ThreadSanitizer in caching pool (pjsip#3897)

* Fixed Metal renderer memory leak (pjsip#3909)

* Fixed DTLS clock stoppage race (pjsip#3905)

* Improve IP address change IPv4 <-> IPv6 (pjsip#3910)

* pjsua_acc: Fix warnings for comparison between ‘pjsua_nat64_opt’ and ‘enum pjsua_ipv6_use’ (pjsip#3915)

* Fix to ext_fmts accessed out of stack scope. (pjsip#3916)

* Add check in siprtp sample app for inactive audio media (pjsip#3927)

* Add function to initialize MediaFormat audio & video (pjsip#3925)

* Fixed incorrect SDP buffer length calculation (pjsip#3924)

* Support Push Notification in iOS sample app (pjsip#3913)

* Fixed PJSUA2 API to get/set Opus config (pjsip#3935)

* Fix bad address length check in pj_ioqueue_sendto(). (pjsip#3941)

* Fix warning of uninitialized value in fuzz-crypto (pjsip#3946)

* Print log on successful send (pjsip#3942)

* Fixed CI Mac build failure (pjsip#3947)

* Update Android JNI audio dev to use 16bit PCM only (pjsip#3945)

* Add TLS/SSL backend: Windows Schannel (pjsip#3867)

* pjsip_find_msg: Log warning if Content-Length field not found (pjsip#3960)

* Fix audiodev index (pjsip#3962)

* Fix assertion on call hangup from DTMF callback (pjsip#3970)

* Fix yaml error in github feature template (pjsip#3972)

* Fix version string in Python setup (pjsip#3976)

* Prevent pjmedia_codec_param.info.enc_ptime_denum division by zero in stream (pjsip#3975)

---------

Co-authored-by: naf <naf@sdf.org>
Co-authored-by: Goodicus <15110766+goodicus@users.noreply.github.com>
Co-authored-by: Amilcar Ubiera <chopin952@gmail.com>
Co-authored-by: Santiago De la Cruz <51337247+xhit@users.noreply.github.com>
Co-authored-by: sauwming <ming@teluu.com>
Co-authored-by: Nanang Izzuddin <nanang@teluu.com>
Co-authored-by: dshamaev-intermedia <105777082+dshamaev-intermedia@users.noreply.github.com>
Co-authored-by: CI Bot <noreply@intermedia.com>
Co-authored-by: Pau Espin Pedrol <pespin.shar@gmail.com>
Co-authored-by: Riza Sulistyo <trengginas@users.noreply.github.com>
Co-authored-by: Andreas Peldszus <andreas.peldszus@posteo.de>
@sauwming sauwming mentioned this pull request Nov 28, 2024
Closed
BarryYin pushed a commit to BarryYin/pjproject that referenced this pull request Feb 3, 2026
@sauwming
Support Push Notification in iOS sample app (pjsip#3913)
7cf0afe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanangizz nanangizz nanangizz approved these changes

@trengginas trengginas Awaiting requested review from trengginas

Assignees

@sauwming sauwming

Labels

component: applications type: enhancement

Projects

None yet

Milestone

release-2.15

Development

Successfully merging this pull request may close these issues.

2 participants

@sauwming @nanangizz